Mercurial > hg > nginx
changeset 8917:bb1d1d9d76e2 quic
QUIC: removed excessive check.
The c->udp->dgram may be NULL only if the quic connection was just
created: the ngx_event_udp_recvmsg() passes information about datagrams
to existing connections by providing information in c->udp.
If case of a new connection, c->udp is allocated by the QUIC code during
creation of quic connection (it uses c->sockaddr to initialize qsock->path).
Thus the check for qsock->path is excessive and can be read wrong, assuming
that other options possible, leading to warnings from clang static analyzer.
author | Vladimir Homutov <vl@nginx.com> |
---|---|
date | Wed, 01 Dec 2021 18:33:29 +0300 |
parents | ff473a6f656c |
children | 606bf52888d2 |
files | src/event/quic/ngx_event_quic_migration.c |
diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/event/quic/ngx_event_quic_migration.c Tue Nov 30 14:30:59 2021 +0300 +++ b/src/event/quic/ngx_event_quic_migration.c Wed Dec 01 18:33:29 2021 +0300 @@ -289,7 +289,7 @@ qsock = ngx_quic_get_socket(c); - if (c->udp->dgram == NULL && qsock->path) { + if (c->udp->dgram == NULL) { /* 1st ever packet in connection, path already exists */ path = qsock->path; goto update;