Mercurial > hg > nginx
changeset 4065:227a819b46db
Proper setting of read->eof in pipe code.
Setting read->eof to 0 seems to be just a typo. It appeared in
nginx-0.0.1-2003-10-28-18:45:41 import (r164), while identical code in
ngx_recv.c introduced in the same import do actually set read->eof to 1.
Failure to set read->eof to 1 results in EOF not being generally detectable
from connection flags. On the other hand, kqueue won't report any read
events on such a connection since we use EV_CLEAR. This resulted in read
timeouts if such connection was cached and used for another request.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Thu, 01 Sep 2011 15:10:41 +0000 |
parents | 5b776ad53c3c |
children | ac19e755a132 |
files | src/event/ngx_event_pipe.c |
diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/event/ngx_event_pipe.c Thu Sep 01 13:49:36 2011 +0000 +++ b/src/event/ngx_event_pipe.c Thu Sep 01 15:10:41 2011 +0000 @@ -149,7 +149,7 @@ && p->upstream->read->pending_eof) { p->upstream->read->ready = 0; - p->upstream->read->eof = 0; + p->upstream->read->eof = 1; p->upstream_eof = 1; p->read = 1;