Mercurial > hg > nginx
diff src/core/ngx_connection.c @ 5137:f941cf265cc5
Use NGX_FILE_ERROR for handling file operations errors.
On Win32 platforms 0 is used to indicate errors in file operations, so
comparing against -1 is not portable.
This was not much of an issue in patched code, since only ngx_fd_info() test
is actually reachable on Win32 and in worst case it might result in bogus
error log entry.
Patch by Piotr Sikora.
author | Valentin Bartenev <vbart@nginx.com> |
---|---|
date | Mon, 25 Mar 2013 15:49:11 +0000 |
parents | a29c574d61fa |
children | 05ba5bce31e0 462ae7eedc68 |
line wrap: on
line diff
--- a/src/core/ngx_connection.c Mon Mar 25 14:51:44 2013 +0000 +++ b/src/core/ngx_connection.c Mon Mar 25 15:49:11 2013 +0000 @@ -412,7 +412,7 @@ } if (ngx_test_config) { - if (ngx_delete_file(name) == -1) { + if (ngx_delete_file(name) == NGX_FILE_ERROR) { ngx_log_error(NGX_LOG_EMERG, cycle->log, ngx_errno, ngx_delete_file_n " %s failed", name); } @@ -739,7 +739,7 @@ { u_char *name = ls[i].addr_text.data + sizeof("unix:") - 1; - if (ngx_delete_file(name) == -1) { + if (ngx_delete_file(name) == NGX_FILE_ERROR) { ngx_log_error(NGX_LOG_EMERG, cycle->log, ngx_socket_errno, ngx_delete_file_n " %s failed", name); }