# HG changeset patch # User Maxim Dounin # Date 1548355860 -10800 # Node ID f3ff79ae31d90436c11b48e3beb7f72fe6640918 # Parent e0e636ab10be265c409f4635ad3ad26c8e97e71f Win32: properly enabled select on Windows. Previously, select was compiled in by default, but the NGX_HAVE_SELECT macro was not set, resulting in iocp being used by default unless the "--with-select_module" configure option was explicitly specified. Since the iocp module is not finished and does not work properly, this effectively meant that the "--with-select_module" option was mandatory. With the change NGX_HAVE_SELECT is properly set, making "--with-select_module" optional. Accordingly, it is removed from misc/GNUmakefile win32 target. diff -r e0e636ab10be -r f3ff79ae31d9 auto/os/win32 --- a/auto/os/win32 Thu Jan 24 21:50:37 2019 +0300 +++ b/auto/os/win32 Thu Jan 24 21:51:00 2019 +0300 @@ -34,6 +34,7 @@ EVENT_FOUND=YES if [ $EVENT_SELECT = NO ]; then + have=NGX_HAVE_SELECT . auto/have CORE_SRCS="$CORE_SRCS $SELECT_SRCS" EVENT_MODULES="$EVENT_MODULES $SELECT_MODULE" fi diff -r e0e636ab10be -r f3ff79ae31d9 misc/GNUmakefile --- a/misc/GNUmakefile Thu Jan 24 21:50:37 2019 +0300 +++ b/misc/GNUmakefile Thu Jan 24 21:51:00 2019 +0300 @@ -65,7 +65,6 @@ --with-cc-opt=-DFD_SETSIZE=1024 \ --with-pcre=$(OBJS)/lib/$(PCRE) \ --with-zlib=$(OBJS)/lib/$(ZLIB) \ - --with-select_module \ --with-http_v2_module \ --with-http_realip_module \ --with-http_addition_module \