# HG changeset patch # User Maxim Dounin # Date 1390392306 -14400 # Node ID 97e3769637a73422c7fc4439807739a29fef9430 # Parent 827e53c136b02b5acb7f1f30b2d60837e1462eaf SSL: fixed $ssl_session_id variable. Previously, it used to contain full session serialized instead of just a session id, making it almost impossible to use the variable in a safe way. Thanks to Ivan Ristić. diff -r 827e53c136b0 -r 97e3769637a7 src/event/ngx_event_openssl.c --- a/src/event/ngx_event_openssl.c Mon Jan 20 20:56:49 2014 +0400 +++ b/src/event/ngx_event_openssl.c Wed Jan 22 16:05:06 2014 +0400 @@ -2504,32 +2504,22 @@ ngx_ssl_get_session_id(ngx_connection_t *c, ngx_pool_t *pool, ngx_str_t *s) { int len; - u_char *p, *buf; + u_char *buf; SSL_SESSION *sess; sess = SSL_get0_session(c->ssl->connection); - len = i2d_SSL_SESSION(sess, NULL); - - buf = ngx_alloc(len, c->log); - if (buf == NULL) { - return NGX_ERROR; - } + buf = sess->session_id; + len = sess->session_id_length; s->len = 2 * len; s->data = ngx_pnalloc(pool, 2 * len); if (s->data == NULL) { - ngx_free(buf); return NGX_ERROR; } - p = buf; - i2d_SSL_SESSION(sess, &p); - ngx_hex_dump(s->data, buf, len); - ngx_free(buf); - return NGX_OK; }