# HG changeset patch # User Roman Arutyunyan # Date 1666187118 -14400 # Node ID 1192923be0aa29aab792bbe3a39ebc93f874a975 # Parent 6546c2ae1c7bd4a734e974c301ec24caff3f3ad3 QUIC: idle mode for main connection. Now main QUIC connection for HTTP/3 always has c->idle flag set. This allows the connection to receive worker shutdown notification. It is passed to application level via a new conf->shutdown() callback. The HTTP/3 shutdown callback sends GOAWAY to client and gracefully shuts down the QUIC connection. diff -r 6546c2ae1c7b -r 1192923be0aa src/event/quic/ngx_event_quic.c --- a/src/event/quic/ngx_event_quic.c Wed Oct 19 17:45:30 2022 +0400 +++ b/src/event/quic/ngx_event_quic.c Wed Oct 19 17:45:18 2022 +0400 @@ -341,6 +341,7 @@ return NULL; } + c->idle = 1; ngx_reusable_connection(c, 1); ngx_log_debug0(NGX_LOG_DEBUG_EVENT, c->log, 0, @@ -420,9 +421,19 @@ } if (c->close) { - qc->error = NGX_QUIC_ERR_NO_ERROR; - qc->error_reason = "graceful shutdown"; - ngx_quic_close_connection(c, NGX_ERROR); + c->close = 0; + + if (!ngx_exiting) { + qc->error = NGX_QUIC_ERR_NO_ERROR; + qc->error_reason = "graceful shutdown"; + ngx_quic_close_connection(c, NGX_ERROR); + return; + } + + if (!qc->closing && qc->conf->shutdown) { + qc->conf->shutdown(c); + } + return; } diff -r 6546c2ae1c7b -r 1192923be0aa src/event/quic/ngx_event_quic.h --- a/src/event/quic/ngx_event_quic.h Wed Oct 19 17:45:30 2022 +0400 +++ b/src/event/quic/ngx_event_quic.h Wed Oct 19 17:45:18 2022 +0400 @@ -28,6 +28,9 @@ #define NGX_QUIC_STREAM_UNIDIRECTIONAL 0x02 +typedef void (*ngx_quic_shutdown_pt)(ngx_connection_t *c); + + typedef enum { NGX_QUIC_STREAM_SEND_READY = 0, NGX_QUIC_STREAM_SEND_SEND, @@ -74,6 +77,8 @@ ngx_int_t stream_reject_code_uni; ngx_int_t stream_reject_code_bidi; + ngx_quic_shutdown_pt shutdown; + u_char av_token_key[NGX_QUIC_AV_KEY_LEN]; u_char sr_token_key[NGX_QUIC_SR_KEY_LEN]; } ngx_quic_conf_t; diff -r 6546c2ae1c7b -r 1192923be0aa src/http/v3/ngx_http_v3.h --- a/src/http/v3/ngx_http_v3.h Wed Oct 19 17:45:30 2022 +0400 +++ b/src/http/v3/ngx_http_v3.h Wed Oct 19 17:45:18 2022 +0400 @@ -141,6 +141,7 @@ uint64_t next_push_id; uint64_t max_push_id; uint64_t goaway_push_id; + uint64_t next_request_id; off_t total_bytes; off_t payload_bytes; @@ -158,6 +159,7 @@ void ngx_http_v3_reset_connection(ngx_connection_t *c); ngx_int_t ngx_http_v3_init_session(ngx_connection_t *c); ngx_int_t ngx_http_v3_check_flood(ngx_connection_t *c); +void ngx_http_v3_shutdown(ngx_connection_t *c); ngx_int_t ngx_http_v3_read_request_body(ngx_http_request_t *r); ngx_int_t ngx_http_v3_read_unbuffered_request_body(ngx_http_request_t *r); diff -r 6546c2ae1c7b -r 1192923be0aa src/http/v3/ngx_http_v3_module.c --- a/src/http/v3/ngx_http_v3_module.c Wed Oct 19 17:45:30 2022 +0400 +++ b/src/http/v3/ngx_http_v3_module.c Wed Oct 19 17:45:18 2022 +0400 @@ -249,6 +249,8 @@ h3scf->quic.stream_reject_code_bidi = NGX_HTTP_V3_ERR_REQUEST_REJECTED; h3scf->quic.active_connection_id_limit = NGX_CONF_UNSET_UINT; + h3scf->quic.shutdown = ngx_http_v3_shutdown; + return h3scf; } diff -r 6546c2ae1c7b -r 1192923be0aa src/http/v3/ngx_http_v3_request.c --- a/src/http/v3/ngx_http_v3_request.c Wed Oct 19 17:45:30 2022 +0400 +++ b/src/http/v3/ngx_http_v3_request.c Wed Oct 19 17:45:18 2022 +0400 @@ -100,6 +100,37 @@ } +void +ngx_http_v3_shutdown(ngx_connection_t *c) +{ + ngx_http_v3_session_t *h3c; + + ngx_log_debug0(NGX_LOG_DEBUG_HTTP, c->log, 0, "http3 shutdown"); + + h3c = ngx_http_v3_get_session(c); + + if (h3c == NULL) { + ngx_quic_finalize_connection(c, NGX_HTTP_V3_ERR_NO_ERROR, + "connection shutdown"); + return; + } + + if (!h3c->goaway) { + h3c->goaway = 1; + +#if (NGX_HTTP_V3_HQ) + if (!h3c->hq) +#endif + { + (void) ngx_http_v3_send_goaway(c, h3c->next_request_id); + } + + ngx_http_v3_shutdown_connection(c, NGX_HTTP_V3_ERR_NO_ERROR, + "connection shutdown"); + } +} + + static void ngx_http_v3_init_request_stream(ngx_connection_t *c) { @@ -140,6 +171,8 @@ pc = c->quic->parent; + h3c->next_request_id = c->quic->id + 0x04; + if (n + 1 == clcf->keepalive_requests || ngx_current_msec - pc->start_time > clcf->keepalive_time) { @@ -149,7 +182,7 @@ if (!h3c->hq) #endif { - if (ngx_http_v3_send_goaway(c, (n + 1) << 2) != NGX_OK) { + if (ngx_http_v3_send_goaway(c, h3c->next_request_id) != NGX_OK) { ngx_http_close_connection(c); return; }