"index off;" directive?

Fabiano Furtado fabianofurtado at gmail.com
Wed May 13 13:00:29 UTC 2026


Hi!

On Tue, May 12, 2026 at 7:24 PM Maxim Dounin wrote:
>
> Hello!
>
> [...]
>
> Using "off" as an index file is certainly possible with both
> variants, it just needs to be written as "./off" in some cases
> (always with the loop checks, and when it's the only argument
> otherwise).

OK!

> So I believe the main difference here is how well the behaviour
> matches user expectations, most notably based on the syntax
> provided.

Agreed!

> Committed, thanks for prodding this.

Thank you for accepting my idea and developing the patch! This is my
first contribution to open-source software! :)

Yet, I have one doubt, specifically at the end of the function
ngx_http_index_merge_loc_conf().

[...]
        conf->max_index_len = sizeof(NGX_HTTP_DEFAULT_INDEX);

        return NGX_CONF_OK;  /* Line 435 */
    }

    return NGX_CONF_OK;  /* Line 438 */
}

There are two "return" statements with the same parameter: lines 435 and 438.

At line 435, do we really need this "return" statement, or is it
required to comply with the guidelines from
https://freenginx.org/en/docs/contributing_changes.html ?

Thanks in advance.
Fabiano Furtado


More information about the nginx-devel mailing list