[nginx] SSL: adjusted debug logging of SSL_get_error().

[Maxim Dounin]

details:   http://freenginx.org/hg/nginx/rev/026cfb103af3
branches:  
changeset: 9484:026cfb103af3
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Sun Mar 22 16:26:47 2026 +0300
description:
SSL: adjusted debug logging of SSL_get_error().

Previously, debug logging of SSL_get_error() result in ngx_ssl_write()
and ngx_ssl_sendfile() was done after error code modifications to fix
obvious bugs: incorrect SSL_ERROR_ZERO_RETURN, which is not at all
defined for write operations, and missing SSL_ERROR_SYSCALL in SSL_sendfile().
This approach, however, somewhat complicates testing of new OpenSSL
versions, where error codes might be returned differently.  As such,
now logging is done immediately after SSL_get_error(), before any
modifications.

diffstat:

 src/event/ngx_event_openssl.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (39 lines):

diff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c
--- a/src/event/ngx_event_openssl.c
+++ b/src/event/ngx_event_openssl.c
@@ -3377,6 +3377,8 @@ ngx_ssl_write(ngx_connection_t *c, u_cha
 
     sslerr = SSL_get_error(c->ssl->connection, n);
 
+    ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL_get_error: %d", sslerr);
+
     if (sslerr == SSL_ERROR_ZERO_RETURN) {
 
         /*
@@ -3389,8 +3391,6 @@ ngx_ssl_write(ngx_connection_t *c, u_cha
         sslerr = SSL_ERROR_SYSCALL;
     }
 
-    ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL_get_error: %d", sslerr);
-
     if (sslerr == SSL_ERROR_WANT_WRITE) {
 
         if (c->ssl->saved_read_handler) {
@@ -3655,6 +3655,8 @@ ngx_ssl_sendfile(ngx_connection_t *c, ng
 
     sslerr = SSL_get_error(c->ssl->connection, n);
 
+    ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL_get_error: %d", sslerr);
+
     if (sslerr == SSL_ERROR_ZERO_RETURN) {
 
         /*
@@ -3679,8 +3681,6 @@ ngx_ssl_sendfile(ngx_connection_t *c, ng
         sslerr = SSL_ERROR_SYSCALL;
     }
 
-    ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL_get_error: %d", sslerr);
-
     if (sslerr == SSL_ERROR_WANT_WRITE) {
 
         if (c->ssl->saved_read_handler) {