[PATCH] Tests: adjusted TODOs for variable evaluation tests

Maxim Dounin mdounin at mdounin.ru
Sun Jul 19 00:02:23 UTC 2026


# HG changeset patch
# User Maxim Dounin <mdounin at mdounin.ru>
# Date 1784416251 -10800
#      Sun Jul 19 02:10:51 2026 +0300
# Node ID 2cbdf8a573d9d8ee60bfc8e3258674281e6b0232
# Parent  8af94668705c15b5eceb76e619c38f6a87c9f2c2
Tests: adjusted TODOs for variable evaluation tests.

diff --git a/access_log_script.t b/access_log_script.t
--- a/access_log_script.t
+++ b/access_log_script.t
@@ -72,7 +72,8 @@ TODO: {
 todo_skip 'might coredump', 2
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 # map with side effects might result in incorrect buffer size
 # and buffer overrun
diff --git a/fastcgi_header_params.t b/fastcgi_header_params.t
--- a/fastcgi_header_params.t
+++ b/fastcgi_header_params.t
@@ -99,7 +99,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map/test-long-uri'), qr!foo .* /map/test-long-uri end!,
 	'fastcgi params and map with side effects');
diff --git a/grpc_headers.t b/grpc_headers.t
--- a/grpc_headers.t
+++ b/grpc_headers.t
@@ -108,7 +108,8 @@ TODO: {
 todo_skip 'might coredump', 2
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/test-long-uri'), qr!blah .* /test-long-uri end!,
 	'grpc_set_header and map with side effects');
diff --git a/http_try_files.t b/http_try_files.t
--- a/http_try_files.t
+++ b/http_try_files.t
@@ -416,7 +416,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map/test-long-uri'), qr!404 Not!,
 	'try_files and map with side effects');
diff --git a/index.t b/index.t
--- a/index.t
+++ b/index.t
@@ -156,7 +156,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map/test-long-uri/'), qr!X-URI: /index.html\x0d($).*body!ms,
 	'index and map with side effects');
diff --git a/proxy_set_body.t b/proxy_set_body.t
--- a/proxy_set_body.t
+++ b/proxy_set_body.t
@@ -97,7 +97,8 @@ TODO: {
 todo_skip 'might coredump', 2
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map'), qr!X-Body: body .* /map end!,
 	'proxy_set_body and map with side effects');
diff --git a/rewrite.t b/rewrite.t
--- a/rewrite.t
+++ b/rewrite.t
@@ -290,7 +290,8 @@ TODO: {
 todo_skip 'might coredump', 2
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map/test-long-uri'), qr!Location: .*/map/test-long-uri!ms,
 	'rewrite and map with side effects');
diff --git a/rewrite_set.t b/rewrite_set.t
--- a/rewrite_set.t
+++ b/rewrite_set.t
@@ -201,7 +201,8 @@ TODO: {
 todo_skip 'might coredump', 5
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 # map can change other variables via named captures,
 # resulting in invalid buffer length calculations
diff --git a/scgi.t b/scgi.t
--- a/scgi.t
+++ b/scgi.t
@@ -117,7 +117,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map/test-long-uri'), qr!foo .* /map/test-long-uri end!,
 	'scgi params and map with side effects');
diff --git a/stream_access_log_script.t b/stream_access_log_script.t
--- a/stream_access_log_script.t
+++ b/stream_access_log_script.t
@@ -59,7 +59,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 # map with side effects might result in incorrect buffer size
 # and buffer overrun
diff --git a/stream_set.t b/stream_set.t
--- a/stream_set.t
+++ b/stream_set.t
@@ -79,7 +79,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 is(stream('127.0.0.1:' . port(8084))->read(), '0 0',
 	'set and map with side effects');
diff --git a/uwsgi.t b/uwsgi.t
--- a/uwsgi.t
+++ b/uwsgi.t
@@ -139,7 +139,8 @@ TODO: {
 todo_skip 'might coredump', 1
 	unless $t->has_version('1.31.3')
 	or $ENV{TEST_NGINX_UNSAFE};
-local $TODO = 'not yet', $t->todo_alerts();
+local $TODO = 'not yet', $t->todo_alerts()
+	unless $t->has_version('1.31.4');
 
 like(http_get('/map/test-long-uri'), qr!foo .* /map/test-long-uri end!,
 	'uwsgi params and map with side effects');



More information about the nginx-devel mailing list