[PATCH 4 of 4] Stream: added MPTCP support

[maxime]

# HG changeset patch
# User maxime <mux99 at live.be>
# Date 1715859942 -7200
#      Thu May 16 13:45:42 2024 +0200
# Node ID bda663d8a1258a10f0312a8d2b272ff98e24fd1f
# Parent  71a8642308e94bf1005a8f4927506c142742260b
Stream: added MPTCP support.

Multipath TCP (MPTCP), standardized in RFC8684 [1], is a TCP extension
that enables a TCP connection to use different paths.

Multipath TCP has been used for several use cases. On smartphones, MPTCP
enables seamless handovers between cellular and Wi-Fi networks while
preserving established connections. This use-case is what pushed Apple
to use MPTCP since 2013 in multiple applications [2]. On dual-stack
hosts, Multipath TCP enables the TCP connection to automatically use the
best performing path, either IPv4 or IPv6. If one path fails, MPTCP
automatically uses the other path.

To benefit from MPTCP, both the client and the server have to support
it. Multipath TCP is a backward-compatible TCP extension that is enabled
by default on recent Linux distributions (Debian, Ubuntu, Redhat, ...).
Multipath TCP is included in the Linux kernel since version 5.6 [3].
To use it on Linux, an application must explicitly enable it when
creating the socket. No need to change anything else in the application.

Even if MPTCP is supported by different OS, only Linux supports the
`IPPROTO_MPTCP` protocol, which is why this feature is currently
limited to Linux only.

This patch adds a new parameter 'mptcp' to the  'listen' directive
in the Stream module.

Link: https://www.rfc-editor.org/rfc/rfc8684.html [1]
Link: https://www.tessares.net/apples-mptcp-story-so-far/ [2]
Link: https://www.mptcp.dev [3]

diff --git a/src/stream/ngx_stream.c b/src/stream/ngx_stream.c
--- a/src/stream/ngx_stream.c
+++ b/src/stream/ngx_stream.c
@@ -486,6 +486,7 @@ ngx_stream_optimize_servers(ngx_conf_t *
             ls->handler = ngx_stream_init_connection;
             ls->pool_size = 256;
             ls->type = addr[i].opt.type;
+            ls->protocol = addr[i].opt.protocol;
 
             cscf = addr->opt.ctx->srv_conf[ngx_stream_core_module.ctx_index];
 
diff --git a/src/stream/ngx_stream.h b/src/stream/ngx_stream.h
--- a/src/stream/ngx_stream.h
+++ b/src/stream/ngx_stream.h
@@ -69,6 +69,7 @@ typedef struct {
     int                            fastopen;
 #endif
     int                            type;
+    int                            protocol;
 } ngx_stream_listen_t;
 
 
diff --git a/src/stream/ngx_stream_core_module.c b/src/stream/ngx_stream_core_module.c
--- a/src/stream/ngx_stream_core_module.c
+++ b/src/stream/ngx_stream_core_module.c
@@ -9,6 +9,11 @@
 #include <ngx_core.h>
 #include <ngx_stream.h>
 
+#ifndef IPPROTO_MPTCP
+#define IPPROTO_MPTCP 262
+#endif
+
+
 
 static ngx_int_t ngx_stream_core_preconfiguration(ngx_conf_t *cf);
 static void *ngx_stream_core_create_main_conf(ngx_conf_t *cf);
@@ -654,6 +659,14 @@ ngx_stream_core_listen(ngx_conf_t *cf, n
         }
 #endif
 
+#if (NGX_LINUX)
+        if (ngx_strcmp(value[i].data, "mptcp") == 0) {
+            ls->protocol = IPPROTO_MPTCP;
+            continue;
+        }
+#endif
+
+
         if (ngx_strncmp(value[i].data, "backlog=", 8) == 0) {
             ls->backlog = ngx_atoi(value[i].data + 8, value[i].len - 8);
             ls->bind = 1;
@@ -884,6 +897,12 @@ ngx_stream_core_listen(ngx_conf_t *cf, n
             return "\"fastopen\" parameter is incompatible with \"udp\"";
         }
 #endif
+
+#if (NGX_LINUX)
+        if (ls->protocol == IPPROTO_MPTCP) {
+             return "\"mptcp\" parameter is incompatible with \"udp\"";
+        }
+#endif
     }
 
     for (n = 0; n < u.naddrs; n++) {