[PATCH 1 of 5] Tests: fixed hangs with Net::SSLeay with LibreSSL on macOS

Maxim Dounin mdounin at mdounin.ru
Wed May 1 01:01:47 UTC 2024


# HG changeset patch
# User Maxim Dounin <mdounin at mdounin.ru>
# Date 1714514801 -10800
#      Wed May 01 01:06:41 2024 +0300
# Node ID 3226c8c9a58a97be60cf8b651ac3a48b18d61e82
# Parent  fe6f22da53ec760f7ab138d1d32b7a03ea7bdea3
Tests: fixed hangs with Net::SSLeay with LibreSSL on macOS.

On macOS (as seen on 14.4.1, latest at the moment), Net::SSLeay compiled
with LibreSSL is shipped with the OS (Net::SSLeay 1.88, LibreSSL 3.3.6).
And for some reason mail_ssl_conf_command.t and stream_ssl_conf_command.t
tests hang after the test, waiting indefinitely in reused SSL socket close().

This seems to be an LibreSSL bug in SSL_shutdown() (at least a couple was
fixed in LibreSSL 3.5.0), probably related to session reuse (which do work
in these particular tests due to TLSv1.2 explicitly used for testing).
Still, calling close(SSL_no_shutdown => 1) explicitly is a trivial workaround,
and hence it is implemented.

diff --git a/mail_ssl_conf_command.t b/mail_ssl_conf_command.t
--- a/mail_ssl_conf_command.t
+++ b/mail_ssl_conf_command.t
@@ -103,6 +103,8 @@ like($s->socket()->dump_peer_certificate
 );
 ok($s->socket()->get_session_reused(), 'SessionTicket');
 
+$s->socket()->close(SSL_no_shutdown => 1);
+
 $s = Test::Nginx::IMAP->new(
 	SSL => 1,
 	SSL_cipher_list =>
diff --git a/stream_ssl_conf_command.t b/stream_ssl_conf_command.t
--- a/stream_ssl_conf_command.t
+++ b/stream_ssl_conf_command.t
@@ -104,6 +104,8 @@ like($s->socket()->dump_peer_certificate
 );
 ok($s->socket()->get_session_reused(), 'SessionTicket');
 
+$s->socket()->close(SSL_no_shutdown => 1);
+
 $s = stream(
 	PeerAddr => '127.0.0.1:' . port(8443),
 	SSL => 1,




More information about the nginx-devel mailing list