# HG changeset patch # User Maxim Dounin # Date 1717125768 -10800 # Node ID 0e2b14c7523205179ac53de584eb6153dd9c36e1 # Parent d732a96e05dfcad72b03eb82170e9bd08b2e6aae Tests: avoid changing non-localized $TODO. This ensures that there will be no unrelated effects if the variable is actually changed, such as seen on sanitizer tests in 910:49579dd88e3f (reverted by this change). diff -r d732a96e05df -r 0e2b14c75232 lib/Test/Nginx.pm --- a/lib/Test/Nginx.pm Sat May 25 03:44:55 2024 +0300 +++ b/lib/Test/Nginx.pm Fri May 31 06:22:48 2024 +0300 @@ -69,21 +69,19 @@ my @alerts = $self->read_file('error.log') =~ /.+\[alert\].+/gm; - if ($^O eq 'solaris') { - $Test::Nginx::TODO = 'alerts' if @alerts - && ! grep { $_ !~ /phantom event/ } @alerts; - } - if ($^O eq 'MSWin32') { - my $re = qr/CloseHandle|TerminateProcess/; - $Test::Nginx::TODO = 'alerts' if @alerts - && ! grep { $_ !~ $re } @alerts; - } + local $Test::Nginx::TODO = 'alerts' if @alerts + && $^O eq 'solaris' + && ! grep { $_ !~ /phantom event/ } @alerts; + + local $Test::Nginx::TODO = 'alerts' if @alerts + && $^O eq 'MSWin32' + && ! grep { $_ !~ qr/CloseHandle|TerminateProcess/ } + @alerts; Test::More::is(join("\n", @alerts), '', 'no alerts'); } if (Test::More->builder->expected_tests) { - local $Test::Nginx::TODO; my $errors = $self->read_file('error.log'); $errors = join "\n", $errors =~ /.+Sanitizer.+/gm; Test::More::is($errors, '', 'no sanitizer errors');