Mercurial > hg > nginx-tests
view proxy_request_buffering.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 882267679006 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # (C) Sergey Kandaurov # (C) Nginx, Inc. # Tests for unbuffered request body. ############################################################################### use warnings; use strict; use Test::More; use Socket qw/ CRLF /; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http proxy rewrite/)->plan(18); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% server { listen 127.0.0.1:8080; server_name localhost; client_header_buffer_size 1k; proxy_request_buffering off; location / { client_body_buffer_size 2k; add_header X-Body "$request_body"; proxy_pass http://127.0.0.1:8081; } location /small { client_body_in_file_only on; proxy_pass http://127.0.0.1:8080/; } location /single { client_body_in_single_buffer on; add_header X-Body "$request_body"; proxy_pass http://127.0.0.1:8081; } location /discard { return 200 "TEST\n"; } location /preread { proxy_pass http://127.0.0.1:8082/; } location /error_page { proxy_pass http://127.0.0.1:8081/404; error_page 404 /404; proxy_intercept_errors on; } location /404 { return 200 "$request_body\n"; } } server { listen 127.0.0.1:8081; server_name localhost; location / { proxy_pass http://127.0.0.1:8080/discard; } location /404 { } } } EOF $t->run(); ############################################################################### unlike(http_get('/'), qr/X-Body:/ms, 'no body'); like(http_get_body('/', '0123456789'), qr/X-Body: 0123456789\x0d?$/ms, 'body'); like(http_get_body('/', '0123456789' x 128), qr/X-Body: (0123456789){128}\x0d?$/ms, 'body in two buffers'); like(http_get_body('/single', '0123456789' x 128), qr/X-Body: (0123456789){128}\x0d?$/ms, 'body in single buffer'); like(http_get_body('/error_page', '0123456789'), qr/^0123456789$/m, 'body in error page'); # pipelined requests like(http_get_body('/', '0123456789', '0123456789' x 128, '0123456789' x 512, 'foobar'), qr/X-Body: foobar\x0d?$/ms, 'body pipelined'); like(http_get_body('/', '0123456789' x 128, '0123456789' x 512, '0123456789', 'foobar'), qr/X-Body: foobar\x0d?$/ms, 'body pipelined 2'); like(http_get_body('/discard', '0123456789', '0123456789' x 128, '0123456789' x 512, 'foobar'), qr/(TEST.*){4}/ms, 'body discard'); like(http_get_body('/discard', '0123456789' x 128, '0123456789' x 512, '0123456789', 'foobar'), qr/(TEST.*){4}/ms, 'body discard 2'); # proxy with file only is disabled in unbuffered mode like(http_get_body('/small', '0123456789'), qr/X-Body: 0123456789\x0d?$/ms, 'small body in file only'); # interactive tests my $s = get_body('/preread', port(8082), 10); ok($s, 'no preread'); SKIP: { skip 'no preread failed', 3 unless $s; is($s->{upload}('01234'), '01234', 'no preread - body part'); is($s->{upload}('56789'), '56789', 'no preread - body part 2'); like($s->{http_end}(), qr/200 OK/, 'no preread - response'); } $s = get_body('/preread', port(8082), 10, '01234'); ok($s, 'preread'); SKIP: { skip 'preread failed', 3 unless $s; is($s->{preread}, '01234', 'preread - preread'); is($s->{upload}('56789'), '56789', 'preread - body'); like($s->{http_end}(), qr/200 OK/, 'preread - response'); } ############################################################################### sub http_get_body { my $uri = shift; my $last = pop; return http( join '', (map { my $body = $_; "GET $uri HTTP/1.1" . CRLF . "Host: localhost" . CRLF . "Content-Length: " . (length $body) . CRLF . CRLF . $body } @_), "GET $uri HTTP/1.1" . CRLF . "Host: localhost" . CRLF . "Connection: close" . CRLF . "Content-Length: " . (length $last) . CRLF . CRLF . $last ); } sub get_body { my ($url, $port, $length, $body) = @_; my ($server, $client, $s); $server = IO::Socket::INET->new( Proto => 'tcp', LocalHost => '127.0.0.1', LocalPort => $port, Listen => 5, Reuse => 1 ) or die "Can't create listening socket: $!\n"; my $r = <<EOF; GET $url HTTP/1.1 Host: localhost Connection: close Content-Length: $length EOF if (defined $body) { $r .= $body; } $s = http($r, start => 1); eval { local $SIG{ALRM} = sub { die "timeout\n" }; local $SIG{PIPE} = sub { die "sigpipe\n" }; alarm(5); $client = $server->accept(); log2c("(new connection $client)"); alarm(0); }; alarm(0); if ($@) { log_in("died: $@"); return undef; } $client->sysread(my $buf, 1024); log2i($buf); $buf =~ s/.*?\x0d\x0a?\x0d\x0a?(.*)/$1/ms; my $f = { preread => $buf }; $f->{upload} = sub { my $buf = shift; eval { local $SIG{ALRM} = sub { die "timeout\n" }; local $SIG{PIPE} = sub { die "sigpipe\n" }; alarm(5); log_out($buf); $s->write($buf); $client->sysread($buf, 1024); log2i($buf); alarm(0); }; alarm(0); if ($@) { log_in("died: $@"); return undef; } return $buf; }; $f->{http_end} = sub { my $buf = ''; $client->write(<<EOF); HTTP/1.1 200 OK Connection: close X-Port: $port OK EOF $client->close; eval { local $SIG{ALRM} = sub { die "timeout\n" }; local $SIG{PIPE} = sub { die "sigpipe\n" }; alarm(5); $s->sysread($buf, 1024); log_in($buf); alarm(0); }; alarm(0); if ($@) { log_in("died: $@"); return undef; } return $buf; }; return $f; } sub log2i { Test::Nginx::log_core('|| <<', @_); } sub log2o { Test::Nginx::log_core('|| >>', @_); } sub log2c { Test::Nginx::log_core('||', @_); } ###############################################################################