Mercurial > hg > nginx-tests
view h2_error_page.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 236d038dc04a |
children | 716d7500317d |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Tests for HTTP/2 protocol with error_page directive. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::HTTP2; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http http_v2 rewrite/)->plan(2) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% server { listen 127.0.0.1:8080 http2; server_name localhost; lingering_close off; error_page 400 = /close; location / { } location /close { return 444; } } } EOF # suppress deprecation warning open OLDERR, ">&", \*STDERR; close STDERR; $t->run(); open STDERR, ">&", \*OLDERR; ############################################################################### # tests for socket leaks with "return 444" in error_page my ($sid, $frames, $frame); # make sure there is no socket leak when the request is rejected # due to missing mandatory ":scheme" pseudo-header and "return 444;" # is used in error_page 400 (ticket #274) my $s1 = Test::Nginx::HTTP2->new(); $sid = $s1->new_stream({ headers => [ { name => ':method', value => 'GET' }, { name => ':path', value => '/' }, { name => ':authority', value => 'localhost' }]}); $frames = $s1->read(all => [{ type => 'RST_STREAM' }]); ($frame) = grep { $_->{type} eq "RST_STREAM" } @$frames; is($frame->{sid}, $sid, 'error 400 return 444 - missing header'); # make sure there is no socket leak when the request is rejected # due to invalid method with lower-case letters and "return 444;" # is used in error_page 400 (ticket #2455) my $s2 = Test::Nginx::HTTP2->new(); $sid = $s2->new_stream({ method => 'foo' }); $frames = $s2->read(all => [{ type => 'RST_STREAM' }]); ($frame) = grep { $_->{type} eq "RST_STREAM" } @$frames; is($frame->{sid}, $sid, 'error 400 return 444 - invalid header'); # while keeping $s1 and $s2, stop nginx; this should result in # "open socket ... left in connection ..." alerts if any of these # sockets are still open $t->stop(); ###############################################################################